Skip to content

fix(hermes): enable model and reasoning controls - #5001

Draft
nicolasdmolina wants to merge 4 commits into
pingdotgg:experiment/hermes-provider-uifrom
nicolasdmolina:agent/hermes-model-reasoning-controls
Draft

fix(hermes): enable model and reasoning controls#5001
nicolasdmolina wants to merge 4 commits into
pingdotgg:experiment/hermes-provider-uifrom
nicolasdmolina:agent/hermes-model-reasoning-controls

Conversation

@nicolasdmolina

@nicolasdmolina nicolasdmolina commented Jul 30, 2026 •
edited by macroscopeapp Bot
Loading

Copy link
Copy Markdown

This is a stacked follow-up to #4678. It targets experiment/hermes-provider-ui, not main, so the work can be reviewed or folded into the existing Hermes PR without creating a competing implementation.

What Changed

  • Add a protocol v5 catalog exchange for authenticated, provider-qualified Hermes models and reasoning capabilities.
  • Discover catalogs asynchronously per connection generation, use collision-safe request IDs, retain the last good catalog during reconnects, and terminate stale driver streams after instance rebuilds.
  • Apply selected models and explicitly chosen reasoning effort at the Hermes turn boundary, then verify the applied configuration in turn.started.
  • Make model/reasoning configuration transactional across Hermes memory, persistent session state, database metadata, pending notes, and cached agents. Failed or cancelled starts restore the prior state.
  • Keep Hermes's per-model/global reasoning defaults untouched until the user explicitly chooses an override.
  • Let bound Hermes Home/agent composers open the model picker when their connected instance reports real choices; single-model instances remain a static label.

Why

#4678 establishes the Hermes gateway and agent UX, but the connected instance is still exposed as one opaque hermes model and the bound composer cannot change model or reasoning. Hermes already has authenticated model inventory and session-scoped /model and /reasoning surfaces, so T3 can expose those choices without owning provider credentials or bypassing Hermes's runtime resolution.

The transaction and lifecycle guards are necessary because a rejected turn must not leave a persisted half-switch behind, and a reconnect/rebuild must not erase a valid catalog or allow an old driver stream to overwrite its replacement.

UI Changes

  • Before: bound Hermes composers always showed a static Hermes model label.
  • After: the same composer shows the normal model picker when the connected Hermes instance reports multiple models, plus a reasoning selector for capable models.

Screenshots are still pending while this PR is in draft.

Verification

  • 185 targeted TypeScript tests passed across server, web, and contracts.
  • 187 Hermes gateway Python tests passed.
  • Typechecks passed for server, web, contracts, and desktop.
  • Repository lint and formatting checks passed.
  • Ruff, Python compilation, and git diff --check passed.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • Video is not applicable; there are no animation changes

Note

Enable per-session model and reasoning controls in the Hermes gateway adapter

  • Bumps the Hermes gateway wire protocol to v5, adding models.list.request/models.list.response messages and optional modelSelection/reasoningEffort fields on turn.start and turn.started.
  • HermesAdapter now applies model and reasoning selections only at fresh turn boundaries via Hermes session-scoped /model and /reasoning commands, verifies Hermes acknowledges the applied selections in turn.started, and compensates with turn.interrupt if they don't match.
  • HermesDriver performs asynchronous, generation-scoped model catalog discovery without blocking snapshot reads; requiresNewThreadForModelChange is now false.
  • ProviderRegistry.mergeProviderModels retains the previous Hermes model catalog across pending or exhausted discovery snapshots, replacing it only on a completed catalog response.
  • The composer model picker renders as a static label only when the composer is bound and the selected instance has no model choices; otherwise it remains interactive.
  • Risk: sessionModelSwitch capability changes from "unsupported" to "in-session" for all Hermes sessions; clients that inspect this field will see changed behavior.
📊 Macroscope summarized a5c57be. 13 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b3c4b4e4-3ae1-438b-8bec-d9d1ef9ec762

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

macroscopeapp[bot]
macroscopeapp Bot reviewed Jul 30, 2026
View reviewed changes
Comment thread apps/server/src/provider/Drivers/HermesDriver.ts Outdated
Comment thread integrations/hermes-t3-gateway/adapter.py Outdated
Comment thread apps/server/src/provider/Layers/HermesAdapter.ts
macroscopeapp[bot]
macroscopeapp Bot reviewed Jul 30, 2026
View reviewed changes
Comment thread integrations/hermes-t3-gateway/adapter.py
@nicolasdmolina
fix(hermes): complete durable rollback
43febf5
@nicolasdmolina
fix(hermes): avoid clobbering foreign reasoning config
f780d05 
Restore runner-global `_reasoning_config` only while this turn still owns
the value it last observed after dispatch. Session-scoped overrides remain
the transactional source of truth; a later writer is no longer overwritten
on rollback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macroscopeapp macroscopeapp[bot] macroscopeapp[bot] left review comments

Assignees

No one assigned

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nicolasdmolina